Move powershell to 2.0.0-preview3-25426-01 using the .NET CLI 2.0.0-preview2-006502#4144
Conversation
|
|
||
| $dotnetCLIChannel = "preview" | ||
| $dotnetCLIRequiredVersion = "2.0.0-preview1-005952" | ||
| $dotnetCLIRequiredVersion = "2.0.0-preview2-006502" |
There was a problem hiding this comment.
preview3 .NET CLI is still broken, please see the description of this PR.
Now we are using .NET CLI preivew2 to build, but target preview3 .NET Core Framework.
| <PackageReference Include="System.Text.Encodings.Web" Version="4.4.0-preview1-25302-01" /> | ||
| <PackageReference Include="System.Threading.AccessControl" Version="4.4.0-preview1-25302-01" /> | ||
| <PackageReference Include="System.Private.ServiceModel" Version="4.4.0-preview1-25302-01" /> | ||
| <PackageReference Include="System.Data.SqlClient" Version="4.4.0-preview3-25423-02" /> |
There was a problem hiding this comment.
Is 02 expected? or should it be 01?
There was a problem hiding this comment.
Yes, it is expected. Microsoft.NetCore.App 2.0.0-preview3-25426-01 references to packages of the build 25423-02 (built in 6/23). However, for ServiceModel related packages, they only have 25423-01 built on that day, so 25423-01 is used for ServiceModel related packages.
| <ProjectReference Include="..\Microsoft.PowerShell.CoreCLR.AssemblyLoadContext\Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.csproj" /> | ||
| <ProjectReference Include="..\Microsoft.PowerShell.CoreCLR.Eventing\Microsoft.PowerShell.CoreCLR.Eventing.csproj" /> | ||
| <PackageReference Include="Microsoft.Win32.Registry.AccessControl" Version="4.4.0-preview1-25302-01" /> | ||
| <PackageReference Include="Microsoft.Win32.Registry.AccessControl" Version="4.4.0-preview3-25423-02" /> |
There was a problem hiding this comment.
02 is expected. Please see my response above.
| $file.Name | Should be $item_F | ||
| } | ||
| It "Should continue enumerating a directory when a contained item is deleted" { | ||
| # Test is pending on Unix platforms because of a behavior change in the latest .NET Core. |
There was a problem hiding this comment.
The issue #20456 is closed, do we still need to have the test case pending?
There was a problem hiding this comment.
The behavior change was by design, to better align with Full .NET. So yes, this test and the corresponding fix need to be revisited. Here is the tracking issue: #4145
| } | ||
| It "Should continue enumerating a directory when a contained item is renamed" { | ||
| # Test is pending on Unix platforms because of a behavior change in the latest .NET Core. | ||
| # See https://github.com/dotnet/corefx/issues/20456 for more information. |
|
@adityapatwardhan Your comments are addressed, please take another look when you have time. Thanks! |
|
@chuanjiao10 new distro supports are tracked by #3961 |
Fix #3649
Summary
Move PowerShell to .NET Core
2.0.0-preview3-25426-01by explicitly specify theRuntimeFrameworkVersionin .csproj files.2.0.0-preview3CLI doesn't work (see https://github.com/dotnet/cli/issues/7013, it's closed but I don't think it should be), so we use .NET CLI2.0.0-preview2-006502for now.Also add
test/Test.Common.propsto hold common properties for test projects.Note
I have verified the CoreFx issues listed in #3649 are fixed in this .NET Core version.
I have verified that
PackageManagementandPowerShellGettests are all passed.I have verified that
Login-AzureRmAccountfromAzureRM.Netcoreworks in powershell with this .NET Core version.