Checkbox to open PowerShell after the (Windows) installer has finished#4203
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Jul 15, 2017
Merged
Checkbox to open PowerShell after the (Windows) installer has finished#4203daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
…shed. Default value is unchecked. The official WiX guide was followed: http://wixtoolset.org/documentation/manual/v3/howtos/ui_and_localization/run_program_after_install.html
|
@bergmeister, |
SteveL-MSFT
requested changes
Jul 14, 2017
assets/Product.wxs
Outdated
| <Property Id="ARPHELPLINK" Value="$(var.InfoURL)" /> | ||
|
|
||
| <!-- Checkbox to allow starting PowerShell after the installation (in UI mode only) --> | ||
| <Property Id="WIXUI_EXITDIALOGOPTIONALCHECKBOXTEXT" Value="Open PowerShell" /> |
Member
There was a problem hiding this comment.
Replace PowerShell with $(env.ProductName)
Contributor
Author
There was a problem hiding this comment.
Good idea. Done and manually tested on the MSI artifact of CI to verify the CheckBox text is still 'Open PowerShell' after using a variable for it.
…e)" as requested in pull request review.
SteveL-MSFT
approved these changes
Jul 14, 2017
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Thanks for the contribution! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a checkbox (unchecked by default) to the last dialogue of the Windows installer to provide the option of opening PowerShell because that's what most people want to do if they installed PowerShell.