Enable DataRow/DataRowView adapters in PowerShell Core#4258
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Jul 17, 2017
Merged
Enable DataRow/DataRowView adapters in PowerShell Core#4258daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
TravisEz13
reviewed
Jul 17, 2017
| /// <summary> | ||
| /// Deals with DataRow objects | ||
| /// </summary> | ||
| internal class DataRowAdapter : PropertyOnlyAdapter |
Member
There was a problem hiding this comment.
Why don't we follow the one class per file practice?
Member
Author
There was a problem hiding this comment.
Core adapters have always been in the same file. Some of them were moved to ExtraAdapter.cs previously due to missing the corresponding type in CoreCLR. Now we are gradually moving them back.
Member
There was a problem hiding this comment.
The question is more about the project in general.
TravisEz13
approved these changes
Jul 17, 2017
|
Hi @daxian-dbw Any idea when can I test this change? Looking forward to give it a shot. Thanks, |
Member
Author
|
@MaximoTrinidad The release of beta.5 will on 8/3. But you can build powershell locally to verify the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4232
Enable the DataRow/DataRowView adapters in PowerShell Core by moving the implementation from
ExtraAdapter.cstoCoreAdapter.cs.Add basic tests too.