Fix Tests from #4479#4512
Conversation
|
@markekraus, |
|
@markekraus Thanks for fixing the tests. Can you run 'Feature' tests to validate that all the required tests are executed. The documentation for executing additional tests is at: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md Look for the section titled 'Requesting additional tests for a PR' |
|
@markekraus I have pushed an empty commit to execute the feature tests. |
|
@adityapatwardhan Thank you. I will make sure to do this in the future. |
|
@adityapatwardhan The tests pass now. The Travis CI failure appears to be unrelated. |
|
@markekraus Restarted the tests on Travis CI. |
|
@adityapatwardhan All Travis CI Tests passing now as well |
|
@daxian-dbw Can you have a quick look? This fixes the daily build failure. |
|
@markekraus Thanks for fixing the tests. |
My Bad... the tests I had in #4479 were failing in the nightly. This fixes them and now they now pass and fail for the right reasons.