Add more tab completion tests#4560
Merged
adityapatwardhan merged 4 commits intoPowerShell:masterfrom Aug 15, 2017
Merged
Conversation
adityapatwardhan
approved these changes
Aug 11, 2017
Member
adityapatwardhan
left a comment
There was a problem hiding this comment.
LGTM with minor comment.
|
|
||
| AfterAll { | ||
| Pop-Location | ||
| Remove-Item -Path $tempDir -Recurse -Force |
Member
There was a problem hiding this comment.
Please add -ErrorAction SilentlyContinue
iSazonov
reviewed
Aug 12, 2017
| CommandLine = "Test history completion" | ||
| ExecutionStatus = "Stopped" | ||
| StartExecutionTime = "8/11/2017 11:04:10 AM" | ||
| EndExecutionTime = "8/11/2017 11:05:49 AM" |
Collaborator
There was a problem hiding this comment.
The dates is not explicitly used but it is culture dependent. Should our tests work under different cultures?
Member
Author
There was a problem hiding this comment.
Good catch. Will change to use a DataTime object instead.
iSazonov
approved these changes
Aug 15, 2017
Collaborator
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second round of adding tab completion tests - issue: #4160
30 tests are added to improve the test coverage in
CompletionAnalysis.csCompletionAnalysis.cs