Conversation
iSazonov
left a comment
There was a problem hiding this comment.
Nicks should be fixed in all file.
.github/CODEOWNERS
Outdated
| # @daxian-dbw @lzybkr @steveL-MSFT @charub | ||
|
|
||
| # Area: Language | ||
| # daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT |
There was a problem hiding this comment.
daxian-dbw -> @daxian-dbw
.github/CODEOWNERS
Outdated
| # First Lets start with areas with no filters or paths | ||
|
|
||
| # Area: Performance | ||
| # @lzybkr @steveL-MSFT @adityapatwardhan |
There was a problem hiding this comment.
@steveL-MSFT -> @SteveL-MSFT
.github/CODEOWNERS
Outdated
| # @BrucePay @JamesWTruher @steveL-MSFT | ||
|
|
||
| # Area: Security | ||
| # @travisez13 @leeholmes @steveL-MSFT @PaulHigin @chunqingchen |
There was a problem hiding this comment.
@travisez13 -> @TravisEz13
|
I addressed @iSazonov 's feedback |
.github/CODEOWNERS
Outdated
| # @BrucePay @JamesWTruher @SteveL-MSFT | ||
|
|
||
| # Area: Security | ||
| # @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen |
There was a problem hiding this comment.
You should remove Lee and Chunqing
SteveL-MSFT
left a comment
There was a problem hiding this comment.
You should remove my name from everywhere except demos.
|
@SteveL-MSFT Updated |
.github/CODEOWNERS
Outdated
| src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin | ||
|
|
||
| # Area: help | ||
| src/System.Management.Automation/help @@Francisco-Gamino @adityapatwardhan |
There was a problem hiding this comment.
.github/CODEOWNERS
Outdated
|
|
||
| # Area: Debugging | ||
| # Must be below engine to override | ||
| src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin |
.github/CODEOWNERS
Outdated
|
|
||
| # Area: Security | ||
| # @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen | ||
| # @TravisEz13 @leeholmes @PaulHigin @chunqingchen |
There was a problem hiding this comment.
remove leeholmes, he isn't generally available so Paul, Travis, or I will pull him in when needed. Remove chunqing
.github/CODEOWNERS
Outdated
| demos/ @joeyaiello @SteveL-MSFT @HemantMahawar | ||
|
|
||
| # Area: DSC | ||
| src/System.Management.Automation/DscSupport @TravisEz13 |
There was a problem hiding this comment.
You can add dantraMSFT to DSC as well.
|
Travis CI temporary failed - I restarted it. |
Just realized that this cause Jim, Travis and Aditya to be dragged into almost every PR review. |
|
Rules later in the file are supposed to override previous rules. Let's see how it actually works before we change it. |
|
But looking at least one PR it looks like it takes the aggregate of what it finds from the rules. Do you want me to submit a PR removing the area-test rule? |
add codeowner file to automatically assign reviewers and to describe who owns areas.