Update travis-ci script so that PRs can fail due to pester tests#4830
Merged
TravisEz13 merged 7 commits intoPowerShell:masterfrom Sep 13, 2017
Merged
Update travis-ci script so that PRs can fail due to pester tests#4830TravisEz13 merged 7 commits intoPowerShell:masterfrom
TravisEz13 merged 7 commits intoPowerShell:masterfrom
Conversation
Member
|
@TravisEz13 can you please briefly describe the issue, root cause and explain the fix? That would be helpful to the review. |
Member
Author
|
@daxian-dbw updated the description. |
f66f23f to
6a63806
Compare
TravisEz13
commented
Sep 13, 2017
tools/failingTests/fail.tests.ps1
Outdated
Member
Author
There was a problem hiding this comment.
I'll add the line ending later. I'll use this change to remove the tag that forces a test failure.
daxian-dbw
reviewed
Sep 13, 2017
tools/travis.ps1
Outdated
Member
Author
There was a problem hiding this comment.
I rebased and resolved the issue.
…ilure Make Test-PSPesterResults throw if there is a failure
b2ec3e2 to
1fd0c55
Compare
Member
Author
|
Verified tests fail correctly here: https://travis-ci.org/PowerShell/PowerShell/jobs/275168248 |
daxian-dbw
approved these changes
Sep 13, 2017
markekraus
reviewed
Sep 13, 2017
Contributor
markekraus
left a comment
There was a problem hiding this comment.
2 minor formatting comments, otherwise LGTM
build.psm1
Outdated
| [switch]$IncludeFailingTest | ||
| ) | ||
|
|
||
| if($IncludeFailingTest.IsPresent) |
| } | ||
|
|
||
| if($hasRunFailingTestTag) | ||
| { |
markekraus
approved these changes
Sep 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @markekraus
Test-PSPesterResults was expected to throw an error by the travis.ps1. It was only writing to the host.
I've updated Test-PSPesterResults to throw an error after it writes to the host.
I've also added a switch to Start-PSPester which will inject a failing test and the [includeFailingTest] in travis.ps1 which will use this switch so we can verify that it works.