Add a CR to CommandNotFoundException error string#4934
Merged
daxian-dbw merged 1 commit intomasterfrom Sep 29, 2017
Merged
Conversation
We're here at PowerShell Unplugged at Ignite, and this error message could *really* use a carriage return!
SteveL-MSFT
requested changes
Sep 27, 2017
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Thanks for the contribution, but string resources should not contain newlines as it may produce unexpected results when it goes through FormatAndOutput
| </data> | ||
| <data name="CommandNotFoundException" xml:space="preserve"> | ||
| <value>The term '{0}' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.</value> | ||
| <value>The term '{0}' is not recognized as the name of a cmdlet, function, script file, or operable program. |
Member
There was a problem hiding this comment.
Formatting should be handled by FormatAndOutput. String messages should not contain newlines.
Member
There was a problem hiding this comment.
Perhaps adding new newlines is something we should consider for other strings as it can improve readability.
SteveL-MSFT
approved these changes
Sep 29, 2017
Collaborator
|
Please clarify what was idea here. After the change: Or idea was to change command line error formatting? To: |
Collaborator
|
@SteveL-MSFT Could you please clarify? |
Member
|
@iSazonov I believe the intent was to have the next sentence on the next line left justified. The whitespace should have been removed. I'll submit PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're here at PowerShell Unplugged at Ignite, and this error message could really use a carriage return!