Update script to get PSVersion from $PSVersionTable#5045
Update script to get PSVersion from $PSVersionTable#5045adityapatwardhan merged 5 commits intoPowerShell:masterfrom
Conversation
| [ValidateNotNullOrEmpty()] | ||
| [parameter(Mandatory = $true, ParameterSetName = "ByPath")] | ||
| [string] | ||
| $PowerShellVersion = "6.0.0-alpha.8" |
There was a problem hiding this comment.
If the path is provided, we should get the powershell version using powershell -vand get rid of this parameter
There was a problem hiding this comment.
Sounds good. Will make the change.
|
I wonder why the script is in |
adityapatwardhan
left a comment
There was a problem hiding this comment.
Approved with minor comments.
| [ValidateNotNullOrEmpty()] | ||
| [parameter(Mandatory = $true, ParameterSetName = "ByPath")] | ||
| [string] | ||
| $PowerShellVersion = "6.0.0-alpha.8" |
|
@iSazonov This script is to register WinRM endpoint configuration to make |
|
A few clean up items since we are touching this file:
|
| reg.exe import .\$fileName | ||
|
|
||
| # Clean up | ||
| # Remove-Item .\$fileName |
There was a problem hiding this comment.
Clean up should still take place. Just remove the "#" on line 74
|
@SteveL-MSFT Your comment has been addressed. Can you please take another look? |
|
Restarted MacOS build. |
|
@adityapatwardhan The build is still failing, but it's not related to this PR. |
The file
powershell.versionhas been removed as we now figure outPSVersionandGitCommitIdfrom theProductVersionofS,M.A.dll. Update the script to get the PSVersion directly from$PSVersionTable.PSVersion.