Skip to content

Remove dead code#5066

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
lzybkr:remove_ancient_dead_code
Oct 10, 2017
Merged

Remove dead code#5066
daxian-dbw merged 1 commit intoPowerShell:masterfrom
lzybkr:remove_ancient_dead_code

Conversation

@lzybkr
Copy link
Copy Markdown
Contributor

@lzybkr lzybkr commented Oct 9, 2017

Code guarded by the following defines is ancient and has never been
used, so removing.

  • RELATIONSHIP_SUPPORTED
  • SUPPORTS_IMULTIVALUEPROPERTYCMDLETPROVIDER

adityapatwardhan
adityapatwardhan approved these changes Oct 9, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT
Copy link
Copy Markdown
Member

SteveL-MSFT commented Oct 9, 2017

@lzybkr are these used in Windows PowerShell (and thus a breaking change)?

@anmenaga
Copy link
Copy Markdown

anmenaga commented Oct 9, 2017

@SteveL-MSFT I've ran a search on WindowsPS code; I don't see these macros defined anywhere.

@lzybkr
Remove dead code
e48199e 
Code guarded by the following defines is ancient and has never been
used, so removing.

* RELATIONSHIP_SUPPORTED
* SUPPORTS_IMULTIVALUEPROPERTYCMDLETPROVIDER
* SUPPORTS_CMDLETPROVIDER_FILE

Also removed some unused platform dependent unsafe code.
@lzybkr lzybkr force-pushed the remove_ancient_dead_code branch from f45e270 to e48199e Compare October 9, 2017 22:36
@lzybkr
Copy link
Copy Markdown
Contributor Author

lzybkr commented Oct 9, 2017

Right, this code has never been used, probably hasn't been compiled in over 10 years.
I pushed a couple more changes (sorry, force pushed) to remove a little bit more unused dead code (well, the file I removed is probably being compiled, but not used apparently, removed because I saw #if IA64 and was going to kill that, realized I'd never seen that code before, and did a build without it.)

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Oct 9, 2017

A side question, the PSMI code at https://github.com/PowerShell/PowerShell/tree/master/src/System.Management.Automation/engine/PSMI is the prototype code @Indhukrishna worked on about 4 years ago to do powershell remoting over WMI remoting. Do we still need that code?

@Indhukrishna can you please weigh in?

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Oct 10, 2017

I synced with @Indhukrishna offline and submitted PR #5075 to remove PSMI code.

@daxian-dbw daxian-dbw self-assigned this Oct 10, 2017
@daxian-dbw daxian-dbw merged commit 22662c8 into PowerShell:master Oct 10, 2017
@lzybkr lzybkr deleted the remove_ancient_dead_code branch October 10, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@BrucePay BrucePay Awaiting requested review from BrucePay

@anmenaga anmenaga Awaiting requested review from anmenaga

@vors vors Awaiting requested review from vors

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lzybkr @SteveL-MSFT @anmenaga @daxian-dbw @adityapatwardhan