Skip to content

Update instructions for building from source#5072

Merged
daxian-dbw merged 3 commits intoPowerShell:masterfrom
kylesferrazza:build-instructions
Oct 13, 2017
Merged

Update instructions for building from source#5072
daxian-dbw merged 3 commits intoPowerShell:masterfrom
kylesferrazza:build-instructions

Conversation

@kylesferrazza
Copy link
Copy Markdown
Contributor

@kylesferrazza kylesferrazza commented Oct 9, 2017

Internals.md updated to use the new System.Management.Automation dll required for TypeCatalogGen.
Also, build.sh no longer exists, so I added the custom msbuild target to the instructions.

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Oct 10, 2017

@iSazonov Can you review?

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Oct 11, 2017

LGTM.

Out of the PR.
@daxian-dbw About "lack of GetAssemblies()" - it seems .Net Core 2.0 has it. Can we remove TypeCatalogGen? I don't found a tracking Issue.

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Oct 12, 2017

@iSazonov we cannot remove TypeCatalogGen. When you use a type like [System.Net.Http.HttpClient], the type catalog generated by TypeCatalogGen kicks in to figure out which assembly should be loaded. The type catalog also plays a role when you are doing a tab completion on a type like [httpcl<tab>. The reason is that GetAssemblies() can only give you the loaded assemblies, so without the type catalog, you need to make sure System.Net.Http.dll is loaded before using any types from it.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Oct 12, 2017

@daxian-dbw Thanks for clarify!
This comment in the code is misleading and must be corrected.

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Oct 12, 2017

@iSazonov Agreed. I will send out a PR shortly to correct it.

@daxian-dbw daxian-dbw mentioned this pull request Oct 12, 2017
Merged
@daxian-dbw daxian-dbw merged commit a2dc405 into PowerShell:master Oct 13, 2017
@kylesferrazza kylesferrazza deleted the build-instructions branch October 13, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kylesferrazza @TravisEz13 @iSazonov @daxian-dbw