Disable cmdlets that are not supported under unix system by chunqingchen · Pull Request #5083 · PowerShell/PowerShell

chunqingchen · 2017-10-11T08:44:13Z

resolve #4355

Removed cmdlets from IntialSessionState.cs so they will not be available on unix platforms.

iSazonov · 2017-10-11T13:34:34Z

Usually we exclude not ported cmdlets with #if !UNIX (or exclude whole file in csproj) and remove from psd1

Also we need correct tests in DefaultCommands.Tests.ps1

chunqingchen · 2017-10-18T07:14:13Z

@iSazonov in issue #4355 you mentioned not implantation exception should be added instead of excluding the cmdlets. Is that not the case now?

iSazonov · 2017-10-18T10:59:58Z

@chunqingchen Sorry, my comment was not approved. I remember @daxian-dbw said that it is better exclude code in csproj - it is easy to track. @daxian-dbw Could you confirm?

adityapatwardhan · 2017-10-17T17:32:59Z

src/System.Management.Automation/engine/remoting/commands/ConnectPSSession.cs

Extra line added.

adityapatwardhan · 2017-10-17T17:35:16Z

src/System.Management.Automation/engine/remoting/commands/CustomShellCommands.cs

Would ! Platform.IsWindows work?

adityapatwardhan · 2017-10-23T19:27:17Z

test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1

For consistency sake, can we use non-windows path here?

adityapatwardhan · 2017-10-23T19:27:27Z

test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1

For consistency sake, can we use non-windows path here?

chunqingchen · 2017-10-27T10:44:23Z

@adityapatwardhan your comments are resolved.

TravisEz13 · 2017-10-28T17:50:27Z

The last commit is lot linked to a github account. Please resolve.

adityapatwardhan · 2017-10-31T22:37:08Z

@chunqingchen The title and the description needs to be updated to match the implementation.

… tests to defaultcommands.tests.ps1

chunqingchen · 2017-11-01T08:56:00Z

@adityapatwardhan updated

iSazonov · 2017-11-01T10:11:23Z

src/System.Management.Automation/engine/InitialSessionState.cs

        public void LoadCommandStop(string Name) { WriteEvent(26, Name); }
    }
-}
+}


Please add new line at EOF.

@chunqingchen Sorry, we should add newline after the last brace not before.

iSazonov · 2017-11-01T10:11:35Z

test/powershell/engine/Basic/DefaultCommands.Tests.ps1

        Test-Path Function:more | Should Be $true
    }
-}
+}


Please add new line at EOF.

@chunqingchen Sorry, we should add newline after the last brace not before.

chunqingchen · 2017-11-01T20:57:38Z

@iSazonov your comment is resolved

iSazonov

Leave a comment

iSazonov · 2017-11-02T03:09:58Z

test/powershell/engine/Basic/DefaultCommands.Tests.ps1

        Test-Path Function:more | Should Be $true
    }
-}
+}


@chunqingchen Sorry, we should add newline after the last brace not before.

iSazonov · 2017-11-02T03:10:09Z

src/System.Management.Automation/engine/InitialSessionState.cs

        public void LoadCommandStop(string Name) { WriteEvent(26, Name); }
    }
-}
+}


@chunqingchen Sorry, we should add newline after the last brace not before.

TravisEz13 · 2017-11-02T22:53:26Z

src/System.Management.Automation/engine/InitialSessionState.cs

missing newline

TravisEz13 · 2017-11-02T22:53:43Z

test/powershell/engine/Basic/DefaultCommands.Tests.ps1

missing newline

TravisEz13

Fix minor issue and it should be good

chunqingchen · 2017-11-02T23:59:48Z

@TravisEz13 new line added.

iSazonov

Should we exclude the code from compilation?

iSazonov · 2017-11-03T03:26:59Z

src/System.Management.Automation/engine/InitialSessionState.cs

        public void LoadCommandStart(string Name) { WriteEvent(25, Name); }
        public void LoadCommandStop(string Name) { WriteEvent(26, Name); }
    }
+


Please revert the formatting change and remove the line.

iSazonov · 2017-11-03T03:27:10Z

test/powershell/engine/Basic/DefaultCommands.Tests.ps1

    It "Should have 'more' as a function" {
        Test-Path Function:more | Should Be $true
    }
+


Please revert the formatting change and remove the line.

adityapatwardhan · 2017-11-06T18:24:02Z

@chunqingchen Please run all tests using [Feature] in your git commit message.

https://github.com/PowerShell/PowerShell/blob/a1b7f8be3ea4ac7e4f7a67e6261ad68cdb23143d/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr

chunqingchen · 2017-11-08T15:03:28Z

@adityapatwardhan @iSazonov your comments are resolved. Thanks

iSazonov · 2017-11-08T17:37:37Z

I believe the PR need #5379 to pass CI Appveyor.

adityapatwardhan · 2017-11-10T00:25:13Z

@chunqingchen Can you have a look at the Travis CI failure?

iSazonov · 2017-11-10T18:03:19Z

CI Travis was passed but not reported.

adityapatwardhan · 2017-11-10T18:35:15Z

Merging as CI has passed but webhook did not update status to GitHub.

vinodc · 2018-02-21T22:38:34Z

@paulcallen Would you happen to know if New-PSSessionOption has been disabled? We updated to the latest version from 6.0.0 beta1 and this no longer works. It was previously working great and we have been using it with New-PSSessionOption since PowerShell/psl-omi-provider#67 was merged in.

dantraMSFT · 2018-02-22T00:45:09Z

@vinodc I'll dig into this. For now, you can use [System.Management.Automation.Remoting.PSSessionOption]::new() and populate the returned object.

BTW: What's the use case you have for it on Linux. Perhaps it was missed with the cmdlet was removed.

vinodc · 2018-02-22T01:07:04Z

@dantraMSFT Thanks for the quick response. We are programmatically accessing Office 365 PowerShell cmdlets and in the process our code creates PSSessionOption objects. We can work around this temporarily, but wanted to make sure that the overall implementation itself is still supported for related commands used to connect to Office 365 PowerShell, starting with New-PSSessionOption.

On a broader note, this is related to piped commands failing (#6206), where we were recommended to update PowerShell first to see if we could reproduce the failure on the latest version, which resulted in these new issues coming up.

dreyTee · 2019-05-05T18:06:28Z

@paulcallen Would you happen to know if New-PSSessionOption has been disabled?

Have same issue when trying to use WINRM from linux without proper server certificate:
Getting error:
Use the PSSessionOption -SkipCACheck and -SkipCNCheck
Trying to use thes options with New-PSSessionOption but can't:
New-PSSessionOption : The term 'New-PSSessionOption' is not recognized as the name of a cmdlet, function, script file, or operable program.
Please advise a workaround a least.

iSazonov · 2019-05-05T18:31:03Z

@dreyTee Please open new issue for your question.

chunqingchen requested review from PaulHigin, dantraMSFT and mirichmo as code owners October 11, 2017 08:44

iSazonov assigned adityapatwardhan Oct 15, 2017

adityapatwardhan requested changes Oct 23, 2017

View reviewed changes

chunqingchen force-pushed the bugfix1 branch from 50b001f to 14c93c6 Compare October 27, 2017 10:29

chunqingchen requested review from BrucePay, TravisEz13, daxian-dbw and lzybkr as code owners October 27, 2017 10:29

chunqingchen force-pushed the bugfix1 branch 2 times, most recently from bd31660 to 17c7418 Compare October 27, 2017 10:40

chunqingchen force-pushed the bugfix1 branch 2 times, most recently from c8d72b3 to 063b5d1 Compare October 28, 2017 02:16

chunqingchen force-pushed the bugfix1 branch 3 times, most recently from d8d84b3 to d70bbac Compare October 31, 2017 22:28

chunqingchen force-pushed the bugfix1 branch 4 times, most recently from 4781090 to 88fd625 Compare November 1, 2017 05:58

perminently remove cmdlets that are not supported under Unix and move…

7fcf03b

… tests to defaultcommands.tests.ps1

chunqingchen force-pushed the bugfix1 branch from 88fd625 to 7fcf03b Compare November 1, 2017 07:16

chunqingchen changed the title ~~add notimplementedException to cmdlets that are temporary not support…~~ Disable cmdlets that are not supported under unix system Nov 1, 2017

iSazonov reviewed Nov 1, 2017

View reviewed changes

iSazonov reviewed Nov 2, 2017

View reviewed changes

TravisEz13 reviewed Nov 2, 2017

View reviewed changes

src/System.Management.Automation/engine/InitialSessionState.cs Outdated

Copy link
Copy Markdown

Member

TravisEz13 Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

TravisEz13 reviewed Nov 2, 2017

View reviewed changes

test/powershell/engine/Basic/DefaultCommands.Tests.ps1 Outdated

Copy link
Copy Markdown

Member

TravisEz13 Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

TravisEz13 approved these changes Nov 2, 2017

View reviewed changes

adding new line EOF

c1e1184

chunqingchen force-pushed the bugfix1 branch from f4eb37a to c1e1184 Compare November 2, 2017 23:58

iSazonov reviewed Nov 3, 2017

View reviewed changes

[Feature] adding new line EOF

ea3d8f6

adityapatwardhan approved these changes Nov 10, 2017

View reviewed changes

adityapatwardhan merged commit 2be13a6 into PowerShell:master Nov 10, 2017

vinodc mentioned this pull request Feb 22, 2018

pipe for office 365 not working on linux: Get-Mailbox | Get-MailboxPermission #6206

Closed

Conversation

chunqingchen commented Oct 11, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Oct 11, 2017

Uh oh!

chunqingchen commented Oct 18, 2017

Uh oh!

iSazonov commented Oct 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunqingchen commented Oct 27, 2017

Uh oh!

TravisEz13 commented Oct 28, 2017

Uh oh!

adityapatwardhan commented Oct 31, 2017

Uh oh!

chunqingchen commented Nov 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunqingchen commented Nov 1, 2017

Uh oh!

iSazonov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 left a comment

Choose a reason for hiding this comment

Uh oh!

chunqingchen commented Nov 2, 2017

Uh oh!

iSazonov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented Nov 6, 2017

Uh oh!

chunqingchen commented Nov 8, 2017

Uh oh!

iSazonov commented Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adityapatwardhan commented Nov 10, 2017

Uh oh!

iSazonov commented Nov 10, 2017

Uh oh!

adityapatwardhan commented Nov 10, 2017

Uh oh!

vinodc commented Feb 21, 2018

Uh oh!

dantraMSFT commented Feb 22, 2018

Uh oh!

vinodc commented Feb 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chunqingchen commented Oct 11, 2017 •

edited by adityapatwardhan

Loading

iSazonov left a comment •

edited

Loading

iSazonov commented Nov 8, 2017 •

edited

Loading

vinodc commented Feb 22, 2018 •

edited

Loading

dreyTee commented May 5, 2019 •

edited

Loading