-Verbose should not override $ErrorActionPreference#5113
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Oct 26, 2017
Merged
-Verbose should not override $ErrorActionPreference#5113adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
anmenaga
suggested changes
Oct 17, 2017
anmenaga
left a comment
There was a problem hiding this comment.
This change is only for Verbose;
however, original issue says that it was approved for both: Verbose and Debug : "Committee agrees that we should fix this so that -ErrorAction works correctly and not overridden by -Debug or -Verbose".
Should this change be done for Debug as well?
Member
Author
|
@anmenaga that's a fair point about |
Member
Author
|
@anmenaga can you review again? |
adityapatwardhan
requested changes
Oct 18, 2017
| Path = "$testdrive\test.txt"; | ||
| Confirm = $false | ||
| } | ||
| New-Item @params |
anmenaga
approved these changes
Oct 18, 2017
Member
Author
|
@adityapatwardhan can you review again? |
adityapatwardhan
approved these changes
Oct 23, 2017
|
Is this likely to make it into the final for Powershell 6? |
Contributor
|
@mintsoft This was merged to master so it will be in the release unless it needs to be reverted for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2247