Skip to content

Add global.json to pick correct SDK version#5118

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
rkeithhill:rkeithhill/add-global-json
Oct 23, 2017
Merged

Add global.json to pick correct SDK version#5118
daxian-dbw merged 2 commits intoPowerShell:masterfrom
rkeithhill:rkeithhill/add-global-json

Conversation

@rkeithhill
Copy link
Copy Markdown
Collaborator

@rkeithhill rkeithhill commented Oct 14, 2017 •
edited
Loading

Fix #5015

This sets the version of the dotnet SDK that should be used to compile the project. I happen to have newer version of the SDK (2.0.2) on my machine and without this file, the build attempts to use the newer version of the SDK which doesn't work.

BTW if you have 2.0.2 installed, without this file when you run Start-PSBuild you get this warning and the build stops - even if you have 2.0.0 installed:

5> Start-PSBuild
WARNING: The currently installed .NET Command Line Tools is not the required version.

Installed version: 2.0.2
Required version: 2.0.0

Fix steps:

1. Remove the installed version from:
    - on windows '$env:LOCALAPPDATA\Microsoft\dotnet'
    - on macOS and linux '$env:HOME/.dotnet'
2. Run Start-PSBootstrap or Install-Dotnet
3. Start-PSBuild -Clean

markekraus
markekraus suggested changes Oct 14, 2017
View reviewed changes
global.json Outdated
"sdk": {
"version": "2.0.0"
}
} No newline at end of file
Copy link
Copy Markdown
Contributor

@markekraus markekraus Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline at the end of the file.

Copy link
Copy Markdown
Collaborator Author

@rkeithhill rkeithhill Oct 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. BTW the original file was simply the output of running:

dotnet new global.json --sdk-version 2.0.0

@markekraus markekraus requested a review from daxian-dbw October 14, 2017 12:48
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Oct 18, 2017

@daxian-dbw Could you please review this bit change? It looks very good.

@iSazonov iSazonov mentioned this pull request Oct 20, 2017
Closed
@rkeithhill
Copy link
Copy Markdown
Collaborator Author

rkeithhill commented Oct 21, 2017

Any update on this? I'm constantly having to create this file on every new branch I create. Otherwise, I can't build. Plus this allows the PowerShell team to specify which version of the SDK is requires. This will reduce contributor issues when their build fails with the message above. And when the team is ready to move to a later version of the SKD like 2.0.2, the global.json can be updated to reflect that change.

@iSazonov iSazonov mentioned this pull request Oct 23, 2017
Closed
@daxian-dbw daxian-dbw merged commit 6acbf5c into PowerShell:master Oct 23, 2017
@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Oct 23, 2017

@rkeithhill Thanks for this PR! Sorry that we had it slipped off our radar.

@daxian-dbw daxian-dbw mentioned this pull request Oct 23, 2017
Merged
This was referenced Nov 1, 2017
Merged
Closed
@rkeithhill rkeithhill deleted the rkeithhill/add-global-json branch May 29, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@markekraus markekraus markekraus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rkeithhill @iSazonov @daxian-dbw @markekraus @SteveL-MSFT @TravisEz13