Skip to content

Refactor for signing#5300

Merged
TravisEz13 merged 6 commits intoPowerShell:masterfrom
TravisEz13:refactor_for_signing
Nov 2, 2017
Merged

Refactor for signing#5300
TravisEz13 merged 6 commits intoPowerShell:masterfrom
TravisEz13:refactor_for_signing

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

  1. make symbols zip include the crossgen'ed files
  2. make symbols zip include a zip for the publish folder.
  3. make symbols zip not allow PSModuleRestore

Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With minor comment

elseif ($IncludeSymbols.IsPresent) {
$crossGenCorrect = $true

$PSModuleRestoreCorrect = $false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments about this.

@TravisEz13 TravisEz13 merged commit 8fcdc01 into PowerShell:master Nov 2, 2017
@TravisEz13 TravisEz13 deleted the refactor_for_signing branch November 2, 2017 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants