Always run test with crossgen'ed assemblies in CI#5315
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Nov 3, 2017
Merged
Always run test with crossgen'ed assemblies in CI#5315daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
TravisEz13
approved these changes
Nov 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crossgen issue dotnet/coreclr#9745 that causes parser test to hang has been fixed in 2.0.4-servicing preview packages, and we have updated powershell project files to build against that runtime (see PR #5295). So now we need to revert the previous workaround in our CI/test scripts, so that we always run crossgen in our CI build and run tests with the crossgen'ed assemblies.