Automation for PS package validation using Docker containers by anmenaga · Pull Request #5401 · PowerShell/PowerShell

anmenaga · 2017-11-10T00:17:00Z

This automation is used for basic validation of PS packages during a release;
Covered configs:

ubuntu14.04
ubuntu16.04
ubuntu17.04
debian.8
debian.9
centos7
fedora25
fedora26
kalilinux
opensuse42.2

During the process Docker files are filled out and executed with Docker build;
During the build PS packages are downloaded onto Docker containers, installed and selected Pester tests from PowerShell Github repo are executed.

anmenaga · 2017-11-10T00:18:18Z

docker/tests/containerTestCommon.psm1

+        [string]
+        $PSVersion = "6.0.0-beta.9",
+        [string]
+        $TestList = "/PowerShell/test/powershell/Modules/PackageManagement/PackageManagement.Tests.ps1,/PowerShell/test/powershell/engine/Module"


Need to review default set of tests to run.

TravisEz13 · 2017-11-10T17:12:55Z

docker/tests/Templates/centos7/Dockerfile

+RUN curl -L -o powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm {PACKAGELOCATIONSTUB}/powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN yum install -y powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


missing newline at end of file

Updated for all files

TravisEz13 · 2017-11-10T17:13:33Z

docker/tests/containerTestCommon.psm1

+    $results
+
+    return $returnValue
+}


missing newline

TravisEz13 · 2017-11-10T17:16:21Z

docker/tests/containerTestCommon.psm1

+    foreach($file in $tempateFiles)
+    {
+        (Get-Content $file)`
+            -replace $versionRpmStubName,$versionRpmStubValue`


Add args to the dockerfile and pass them in when running build instead.

Good idea; Updated to use --build-arg's

TravisEz13

see comments

TravisEz13 · 2017-11-10T17:19:19Z

docker/tests/Templates/ubuntu17.04/Dockerfile

+RUN dpkg -i powershell_{PSVERSIONSTUB}-1.ubuntu.17.04_amd64.deb || :
+RUN apt-get install -y -f
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


why not use the release dockefiles the just run this command. This would cause less code duplication

These tests are to test the generated packages before publishing them to Microsoft Repository, so the release dockerfiles won't help here. We need to download the packages from the Azure blob.

adityapatwardhan · 2017-11-10T23:07:35Z

docker/tests/Templates/centos7/Dockerfile

+RUN curl -L -o powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm {PACKAGELOCATIONSTUB}/powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN yum install -y powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


Please use full cmdlet name Import-Module

Updated for all files.

adityapatwardhan · 2017-11-10T23:08:01Z

docker/tests/Templates/debian.8/Dockerfile

+RUN dpkg -i powershell_{PSVERSIONSTUB}-1.debian.8_amd64.deb || :
+RUN apt-get install -y -f
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


Same as above

adityapatwardhan · 2017-11-10T23:08:18Z

docker/tests/Templates/debian.9/Dockerfile

+RUN dpkg -i powershell_{PSVERSIONSTUB}-1.debian.9_amd64.deb || :
+RUN apt-get install -y -f
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


Same as above

adityapatwardhan · 2017-11-10T23:08:39Z

docker/tests/Templates/fedora25/Dockerfile

+RUN curl -L -o powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm {PACKAGELOCATIONSTUB}/powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN dnf install -y powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


same as above

adityapatwardhan · 2017-11-10T23:08:52Z

docker/tests/Templates/fedora26/Dockerfile

+RUN curl -L -o powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm {PACKAGELOCATIONSTUB}/powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN dnf install -y powershell-{PSVERSIONSTUBRPM}-1.rhel.7.x86_64.rpm
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


same as above

adityapatwardhan · 2017-11-10T23:09:25Z

docker/tests/Templates/ubuntu16.04/Dockerfile

+RUN dpkg -i powershell_{PSVERSIONSTUB}-1.ubuntu.16.04_amd64.deb || :
+RUN apt-get install -y -f
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


same as above

adityapatwardhan · 2017-11-10T23:09:51Z

docker/tests/Templates/ubuntu17.04/Dockerfile

+RUN dpkg -i powershell_{PSVERSIONSTUB}-1.ubuntu.17.04_amd64.deb || :
+RUN apt-get install -y -f
+RUN git clone --recursive https://github.com/PowerShell/PowerShell.git
+RUN pwsh -c "ipmo /PowerShell/build.psm1;exit (Invoke-Pester {TESTLISTSTUB} -PassThru).FailedCount"


same as above

adityapatwardhan · 2017-11-10T23:14:55Z

docker/tests/containerTestCommon.psm1

+    $packageLocationStubName = '{PACKAGELOCATIONSTUB}'
+    $packageLocationStubValue = $PSPackageLocation
+
+    $tempateFiles = (Get-ChildItem -Recurse -Path $RootFolder -Filter Dockerfile).FullName


typo in variable name $tempateFiles -> $templateFiles

This variable got removed in refactoring.

adityapatwardhan · 2017-11-10T23:28:53Z

docker/tests/containerTestCommon.psm1

+    $results
+
+    return $returnValue
+}


Use Export-ModuleMember to specify which functions are public.

Unless it is required, I'd rather not.
It appears that this module does not do this for other functions.

adityapatwardhan · 2017-11-10T23:30:08Z

docker/tests/containerTestCommon.psm1

+# During the process Docker files are filled out and executed with Docker build;
+# During the build PS packages are downloaded onto Docker containers, installed and selected Pester tests from PowerShell Github repo are executed.
+# This function must be run on a Docker host machine in 'Linux containers' mode, such as Windows 10 server with Hyper-V role installed.
+function ValidatePSPackage


This seems to be a public function, should be named Test-PSPackage

Renamed to Test-PSPackage

PackageValidation automation

f4724b7

anmenaga added the WG-Maintainers-Build specific to affecting the build label Nov 10, 2017

anmenaga requested a review from daxian-dbw November 10, 2017 00:17

anmenaga requested review from TravisEz13 and adityapatwardhan as code owners November 10, 2017 00:17

anmenaga commented Nov 10, 2017

View reviewed changes

TravisEz13 reviewed Nov 10, 2017

View reviewed changes

TravisEz13 requested changes Nov 10, 2017

View reviewed changes

TravisEz13 self-assigned this Nov 10, 2017

TravisEz13 reviewed Nov 10, 2017

View reviewed changes

Fixed file-ending newlines and fedora26 config

2988c16

adityapatwardhan requested changes Nov 10, 2017

View reviewed changes

Andrew added 2 commits November 10, 2017 16:14

Changed to using build-args and other misc updates

58ba3e2

Ending newline in psm1

10e54da

TravisEz13 approved these changes Nov 11, 2017

View reviewed changes

adityapatwardhan approved these changes Nov 13, 2017

View reviewed changes

TravisEz13 merged commit 06d3114 into PowerShell:master Nov 13, 2017

anmenaga deleted the DockerPackageValidation branch October 31, 2018 21:19

Conversation

anmenaga commented Nov 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants