Support '[package]' tag in PR CI and fix nightly build on macOS#5410
Support '[package]' tag in PR CI and fix nightly build on macOS#5410daxian-dbw merged 5 commits intoPowerShell:masterfrom
Conversation
tools/travis.ps1
Outdated
| $hasFeatureTag = $commitMessage -match '\[feature\]' | ||
| $hasRunFailingTestTag = $commitMessage -match '\[includeFailingTest\]' | ||
| $isDailyBuild = $env:TRAVIS_EVENT_TYPE -eq 'cron' -or $env:TRAVIS_EVENT_TYPE -eq 'api' | ||
| $isDailyBuild = $env:TRAVIS_EVENT_TYPE -eq 'cron' -or $env:TRAVIS_EVENT_TYPE -eq 'api' -or $commitMessage -match '\[daily\]' |
There was a problem hiding this comment.
Maybe it's better to also create a variable $hasDailyTag, and use -or $hasDailyTag here.
tools/travis.ps1
Outdated
| $hasFeatureTag = $commitMessage -match '\[feature\]' | ||
| $hasRunFailingTestTag = $commitMessage -match '\[includeFailingTest\]' | ||
| $isDailyBuild = $env:TRAVIS_EVENT_TYPE -eq 'cron' -or $env:TRAVIS_EVENT_TYPE -eq 'api' | ||
| $isDailyBuild = $env:TRAVIS_EVENT_TYPE -eq 'cron' -or $env:TRAVIS_EVENT_TYPE -eq 'api' -or $commitMessage -match '\[daily\]' |
There was a problem hiding this comment.
Not yet. [Daily] tag is not working for AppVeyor PR CIs yet.
Should update docs after enabling the AppVeyor CI.
There was a problem hiding this comment.
We could document that it only works in Travis-CI
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM except for one comment.
|
@SteveL-MSFT Linux CI finished, please check if the package got uploaded. |
664d81f to
ec75cde
Compare
|
For the This comment doesn't block the PR. If we think that's the right way to go, we can submit a separate PR to do it. |
|
@daxian-dbw that makes sense since the intent is to test the packaging |
ec75cde to
52c0462
Compare
tools/appveyor.psm1
Outdated
| # if [Feature] or [Package] is in the commit message, | ||
| # Run Daily tests | ||
| if($env:APPVEYOR_REPO_COMMIT_MESSAGE -match '\[feature\]') | ||
| if($env:APPVEYOR_REPO_COMMIT_MESSAGE -match '(\[feature\])|(\[package\])') |
There was a problem hiding this comment.
We don't need the change in AppVeyor. AppVeyor PR CI always generate packages.
Example: https://ci.appveyor.com/project/PowerShell/powershell/build/6.0.0-beta.9-6723
|
|
||
| # Run a full build if the build was trigger via cron, api or the commit message contains `[Feature]` | ||
| $hasFeatureTag = $commitMessage -match '\[feature\]' | ||
| $hasPackageTag = $commitMessage -match '\[package\]' |
There was a problem hiding this comment.
The line Start-PSBootstrap -Package:(-not $isPr) needs to be updated.
How about change to:
$hasPackageTag = $commitMessage -match '\[package\]'
$createPackages = -not $isPr -or $hasPackageTag
...
Start-PSBootstrap -Package:$createPackages
...
if ($createPackages) {
## create package |
Since the line |
|
per @TravisEz13 Travis-CI doesn't upload the artifacts on PRs, so I'll have to wait til this is merged and a daily build kicks off to verify the actual package got uploaded, but it does appear to have been built |
|
It took forever for the macOS CI to start. I will merge this PR without waiting on the macOS because
|
When using '[package]' tag, regular CI tests will run and packaging steps will also run.