move trust for ProductBinaries to Unrestricted.#5511
move trust for ProductBinaries to Unrestricted.#5511daxian-dbw merged 4 commits intoPowerShell:masterfrom
Conversation
b5e8c7a to
662b32e
Compare
There was a problem hiding this comment.
If the execution policy is unrestricted, then I think we don't need this check anymore.
There was a problem hiding this comment.
Chatted with Travis offline. This check is needed to bypass files downloaded from the internet to $PSHome\Module when it's Unrestricted.
Need to add a comment about this.
There was a problem hiding this comment.
Chatted with Travis offline. This check is needed to bypass files downloaded from the internet to $PSHome\Module when it's Unrestricted.
Need to add a comment about this.
|
Can we add a test? |
7f2fe7b to
73c15ab
Compare
There was a problem hiding this comment.
change to use ShouldBeErrorId?
There was a problem hiding this comment.
Sorry, I accidentally pushed an incomplete commit. I have updated the PR.
cf20b34 to
3094513
Compare
| } | ||
|
|
||
| ) | ||
| foreach($testScript in $testScripts) { |
There was a problem hiding this comment.
Note, $testScripts was not defined in this scope, so nothing was being run.
|
Note, issue #5559 was filed when adding tests due to an issue with the tests. I have marked the affected tests to be skipped. |
| error = $null | ||
| } | ||
| ) | ||
| It "$TestTypePrefix Running <testScript> Script should throw '<error>'" -TestCases $skipTestData -Skip {} |
There was a problem hiding this comment.
Should this be Pending and not Skipped?
fixes #5485