Increase version to 6.1 for PSSessionConfiguration tests#5542
Increase version to 6.1 for PSSessionConfiguration tests#5542markekraus wants to merge 1 commit intoPowerShell:masterfrom
Conversation
|
Can we do these tests more version independent? Can we get the version from |
|
I'm not familiar with these tests or the code they are testing, but, one fear I have about doing that kind of thing is if it is somehow referencing itself. if a corrupt version number is leaking into the PSSession, then the test will pass, even though the expected version is wrong. In that case, we should just remove the test as it wont provide any benefit. That is how we get tests that are passing even though the code is broken. |
|
I think the meaning of this test is that this property has a version the same as the current PowerShell Core version. |
|
Is there a point to that test? What does it test? what is it verifying? why is it important? Maybe it's better to remove this check. if it is just going to echo back the same version every time, is there any value in testing it? Is there any scenario where this would not have the same version? Is this version information significant in any way? Tests are one area where I think it is OK have these kinds of literal tests. They provide more valuable information that way. If the same version just gets echoed back, testing against that same version it is no different than |
|
|
|
@iSazonov so, does this check even matter then? also, please open an issue for the missing tests. |
|
I open PR #5554 to fix CIs and add absent tests. |
bump version to 6.1 for
Get-PSSessionConfigurationandRegister-PSSessionConfigurationtests to prevent false fails (example)