Add retry logic to prerequisite URL tests#5601
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Dec 4, 2017
Merged
Add retry logic to prerequisite URL tests#5601adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
Member
|
Can we try adding a simple retry before disabling? |
Member
Author
|
@SteveL-MSFT Sure, I will use retries and let's see how it goes. |
Member
Author
|
The failed tests are known. #5605 will make them pending for now. |
Collaborator
|
We could run the package prerequisite URL tests with another test tag ("Doc"). |
Contributor
|
I'm not sure what is best for this. We need to ensure the links work, but they erroneously fail often. A retry will help sometimes, but many times when this test fails it fails for days at a time. |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 5, 2017
* Disable Requisiste URLs tests * Add retry for the URL tests
TravisEz13
pushed a commit
that referenced
this pull request
Dec 5, 2017
* Disable Requisiste URLs tests * Add retry for the URL tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package prerequisite URL tests have been failing intermittently recently, because sometimes the WMF download URLs lead to a "we're sorry, this download is no longer available" page, even though the URLs actually work in the web browser. I'm disabling those tests for now.
Close #5567