Make Travis CI use libcurl+openssl+gssapi for macOS#5629
Make Travis CI use libcurl+openssl+gssapi for macOS#5629daxian-dbw merged 4 commits intoPowerShell:masterfrom
Conversation
65a4929 to
a758be9
Compare
|
yay.. all passed this time. So.. the question is where do I document this at? in the web cmdlets documentations? somewhere in this repo (install documentation)? both? |
|
We need to document it in the web cmdlets help content, and point out what parameters are affected by this. |
e232177 to
bbbf5f8
Compare
bbbf5f8 to
3c9e098
Compare
TravisEz13
left a comment
There was a problem hiding this comment.
One comment about another issue this PR brings up, Please file an issue or submit a PR for this and link in this PR.
|
|
||
| # Install patched version of curl | ||
| Start-NativeExecution { brew install curl --with-openssl } -IgnoreExitcode | ||
| Start-NativeExecution { brew install curl --with-openssl --with-gssapi } -IgnoreExitcode |
There was a problem hiding this comment.
We should update the PowerShell brew recipe as well.
https://github.com/caskroom/homebrew-cask/blob/master/Casks/powershell.rb#L33
There was a problem hiding this comment.
We need to figure out what to do with the powershell package about this limitation on macOS.
CoreCLR has explicitly moved away from OpenSSL on mac, see this PR: dotnet/corefx#17011.
Please open an issue to track the macOS packaging about this.
| - Remove Pester as a module include with the PowerShell Packages. | ||
| In the future, you should be able to add it by running `Install-Module Pester`. (#5623, #5631) | ||
| - Make Travis CI use `libcurl+openssl` (#5629, @markekraus) | ||
| - Make Travis CI use `libcurl+openssl+gssapi` (#5629, @markekraus) |
There was a problem hiding this comment.
should only have one line for a single PR
e6896f0 to
5f96cc6
Compare
|
I didn't add the [feature] tag when resolving a conflict. Add the |
Closes #5590
brewinstalledlibcurlthat uses OpenSSL for the crypto provider and include the gssapi option. The native libcurl provides inconsistent feature support across OS versions.PowerShellGetin order to supportHttpClientHandler.UseDefaultCredentialswhich it sets as true (unless you supply credentials).PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsPR Summary