Skip to content

Add Count and Length properties to [PSCustomobject] #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Dec 28, 2017
Merged

Add Count and Length properties to [PSCustomobject] #5745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b2a00
Add Count and Length property to [pscustomobject]
iSazonov Dec 26, 2017
027c44a
Add tests for pscustomobject has a count or length property
iSazonov Dec 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/System.Management.Automation/engine/runtime/Binding/Binders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5690,6 +5690,11 @@ internal static object GetAdaptedValue(object obj, string member)
return memberInfo.Value;
}

if (string.Equals(member, "Length", StringComparison.OrdinalIgnoreCase) || string.Equals(member, "Count", StringComparison.OrdinalIgnoreCase))
{
return 1;
}

if (context != null && context.IsStrictVersion(2))
{
// If the member is undefined and we're in strict mode, throw an exception...
Expand Down
27 changes: 27 additions & 0 deletions test/powershell/engine/ETS/Adapter.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,33 @@ Describe "Adapter Tests" -tags "CI" {
Remove-TypeData TestCodeMethodInvokationWithVoidReturn
}
}

It "Count and length property works for singletons" {
# Return magic Count and Length property if it absent.
$x = 5
$x.Count | Should Be 1
$x.Length | Should Be 1

$null.Count | Should Be 0
$null.Length | Should Be 0

(10).Count | Should Be 1
(10).Length | Should Be 1

("a").Count | Should Be 1
# The Length property exists for strings, so we skip the test in the context.
# ("a").Length | Should Be 1

([psobject] @{ foo = 'bar' }).Count | Should Be 1
([psobject] @{ foo = 'bar' }).Length | Should Be 1

([pscustomobject] @{ foo = 'bar' }).Count | Should Be 1
([pscustomobject] @{ foo = 'bar' }).Length | Should Be 1
Copy link
Copy Markdown
Contributor

@lzybkr lzybkr Dec 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also test when a pscustomobject has a count or length property to make sure we return the correct value.

Copy link
Copy Markdown
Collaborator Author

@iSazonov iSazonov Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


# Return real Count and Length property if it present.
([pscustomobject] @{ foo = 'bar'; count = 5 }).Count | Should Be 5
([pscustomobject] @{ foo = 'bar'; length = 5 }).Length | Should Be 5
}
}

Describe "Adapter XML Tests" -tags "CI" {
Expand Down