Skip to content

Handle spaces in a path in RegisterManifest.ps1#5859

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
tandasat:handle-spaces-in-RegisterManifest.ps1
Jan 11, 2018
Merged

Handle spaces in a path in RegisterManifest.ps1#5859
daxian-dbw merged 1 commit intoPowerShell:masterfrom
tandasat:handle-spaces-in-RegisterManifest.ps1

Conversation

@tandasat
Copy link
Copy Markdown
Contributor

@tandasat tandasat commented Jan 11, 2018

PR Summary

Fix #5858
This change is to handle spaces in a given path and to successfully register / unregister the ETW manifest with RegisterManifest.ps1 on the default install path.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

Description

On Windows, PowerShell 6 is installed into C:\Program Files\PowerShell\6.0.0 by default. RegisterManifest.ps1, which expected to take a path of this location, does not work with the path because it uses the path for wevtutil without quoting it. This results in multiple parameters like C:\Program Files\PowerShell\6.0.0, which is invalid for wevtutil.

This change simply add double quotes when the pass is used for wevtutil.

@daxian-dbw daxian-dbw merged commit 2ae61c8 into PowerShell:master Jan 11, 2018
@tandasat
Copy link
Copy Markdown
Contributor Author

Thank you for review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RegisterManifest.ps1 does not work with the default install path

3 participants