Handle spaces in a path in RegisterManifest.ps1#5859
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Jan 11, 2018
Merged
Handle spaces in a path in RegisterManifest.ps1#5859daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
dantraMSFT
approved these changes
Jan 11, 2018
Contributor
Author
|
Thank you for review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #5858
This change is to handle spaces in a given path and to successfully register / unregister the ETW manifest with RegisterManifest.ps1 on the default install path.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.NA] User facing Documentation neededNA] Make sure you've added a new test if existing tests do not effectively test the code changedNA] Add[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.Description
On Windows, PowerShell 6 is installed into
C:\Program Files\PowerShell\6.0.0by default. RegisterManifest.ps1, which expected to take a path of this location, does not work with the path because it uses the path forwevtutilwithout quoting it. This results in multiple parameters likeC:\ProgramFiles\PowerShell\6.0.0, which is invalid forwevtutil.This change simply add double quotes when the pass is used for
wevtutil.