Skip to content

Fix build/package/installation scripts for SLES#5918

Merged
TravisEz13 merged 3 commits intoPowerShell:masterfrom
tomconte:master
Jan 22, 2018
Merged

Fix build/package/installation scripts for SLES#5918
TravisEz13 merged 3 commits intoPowerShell:masterfrom
tomconte:master

Conversation

@tomconte
Copy link
Copy Markdown
Contributor

@tomconte tomconte commented Jan 16, 2018 •
edited by TravisEz13
Loading

PR Summary

Small changes to the SUSE installation script so that it allows installing on SLES 12+ in addition to openSUSE 42+

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jan 17, 2018

does line 587 in build.psm1 need to be updated as well?

@tomconte
Copy link
Copy Markdown
Contributor Author

tomconte commented Jan 18, 2018 •
edited
Loading

I am working on changes to build.psm1 and packaging.psm1 to allow packaging on SUSE family (openSUSE + SLES) and also creating a specific RPM that has the proper dependencies (to avoid the error message that we currently get when installing the RedHat RPM on SUSE). I will push additional commits to this PR if it works for you!

@tomconte
Copy link
Copy Markdown
Contributor Author

tomconte commented Jan 18, 2018

@TravisEz13 SUSE doesn't need these symlinks AFAICT... It's able to resolve the dynamic libraries properly:

> ldd /opt/microsoft/powershell/6.0.0-124-g75c452c7/libmi.so
        libssl.so.1.0.0 => /lib64/libssl.so.1.0.0 (0x00007fc6b15a8000)
        libcrypto.so.1.0.0 => /lib64/libcrypto.so.1.0.0 (0x00007fc6b114d000)

@tomconte tomconte changed the title Fix installation script for SLES Fix build/package/installation scripts for SLES Jan 18, 2018
@adityapatwardhan
Copy link
Copy Markdown
Member

adityapatwardhan commented Jan 18, 2018

@tomconte Thanks for your contribution!
If you are expecting more changes to this PR, please add a WIP: in the title until it is ready for review. More information here: https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress

@tomconte
Copy link
Copy Markdown
Contributor Author

tomconte commented Jan 18, 2018

Thanks @adityapatwardhan, would appreciate your review now.

@TravisEz13 TravisEz13 merged commit 7dcd4c8 into PowerShell:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomconte @TravisEz13 @adityapatwardhan