Tests for PowerShell hosting API#6737
Merged
daxian-dbw merged 4 commits intoPowerShell:masterfrom Apr 27, 2018
Merged
Conversation
SteveL-MSFT
reviewed
Apr 26, 2018
| @@ -0,0 +1,54 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT License. | |||
| using Xunit; | |||
Member
There was a problem hiding this comment.
add a space after copyright header
daxian-dbw
reviewed
Apr 26, 2018
test/hosting/hosting.tests.csproj
Outdated
| <PropertyGroup> | ||
| <Description>PowerShell hosting SDK xUnit Tests</Description> | ||
| <AssemblyName>powershell-hosting-tests</AssemblyName> | ||
| <RuntimeIdentifiers>win7-x86;win7-x64;osx.10.12-x64;linux-x64</RuntimeIdentifiers> |
Member
There was a problem hiding this comment.
No blocking, just a question :). is the RuntimeIdentifiers tag needed? It seems we are building an assembly instead of an app, so it shouldn't be necessary.
Member
|
Otherwise LGTM |
Member
Author
|
@TravisEz13 updated as discussed. |
TravisEz13
approved these changes
Apr 27, 2018
daxian-dbw
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
These test are used by VSTS build as validation of MyGet packages for PowerShell hosting SDK. They are not part of the CI tests.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests