Skip to content

Fix crash when terminal is reset #6777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
May 8, 2018
Merged

Fix crash when terminal is reset #6777

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ee910a
fix crash when terminal is reset
SteveL-MSFT Apr 30, 2018
96c7060
address Dongbo's feedback
SteveL-MSFT Apr 30, 2018
0b493ea
fix check before removing characters
SteveL-MSFT May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,11 +1790,18 @@ private string ReadLineFromConsole(bool endOnTab, string initialContent, bool ca
continue;
}

// Handle case where terminal gets reset and the index is outside of the buffer
if (index > s.Length)
{
index = s.Length;
}

// Modify string
if (!insertMode) // then overwrite mode
if (!insertMode && index < s.Length) // then overwrite mode
{
s = s.Remove(index, 1);
}

s = s.Insert(index, keyInfo.KeyChar.ToString());
index++;

Expand Down