Skip to content

Updates to fedora27 and kalilinux dockerfiles #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 3 commits into from
May 7, 2018
Merged

Updates to fedora27 and kalilinux dockerfiles #6819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1189f79
Updates to dockerfiles
May 3, 2018
0bf208b
Added applying security updates to the fedora images
May 4, 2018
e5f4e64
Moved upgrade-minimal to 'RUN dnf install' layer
May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/release/fedora26/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ LABEL maintainer="PowerShell Team <[email protected]>" \
RUN dnf install -y \
curl \
glibc-locale-source \
&& dnf upgrade-minimal -y --security \
&& dnf clean all

# Setup the locale
Expand Down
2 changes: 2 additions & 0 deletions docker/release/fedora27/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ LABEL maintainer="PowerShell Team <[email protected]>" \
RUN dnf install -y \
curl \
glibc-locale-source \
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider adding the folloiwng to the image

dnf upgrade-minimal -y --security

This will apply any security updates to the image.

Copy link
Copy Markdown
Author

@anmenaga anmenaga May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea. I've added this change and rerun package tests - build time does not seem to be impacted much.

compat-openssl10 \
&& dnf upgrade-minimal -y --security \
&& dnf clean all

# Setup the locale
Expand Down
4 changes: 3 additions & 1 deletion docker/tests/Templates/fedora26/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ RUN dnf install -y \
curl \
glibc-locale-source \
compat-openssl10 \
git
git \
&& dnf upgrade-minimal -y --security \
&& dnf clean all

# Setup the locale
ENV LANG en_US.UTF-8
Expand Down
5 changes: 4 additions & 1 deletion docker/tests/Templates/fedora27/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ ARG GITLOCATION=https://github.com/PowerShell/PowerShell.git
RUN dnf install -y \
curl \
glibc-locale-source \
git
git \
compat-openssl10 \
&& dnf upgrade-minimal -y --security \
&& dnf clean all

# Setup the locale
ENV LANG en_US.UTF-8
Expand Down
29 changes: 0 additions & 29 deletions docker/tests/Templates/kalilinux/Dockerfile
View file
Open in desktop

This file was deleted.