I think we can remove the asserts now.

Removed.

Since the strings are now user visible, they need to be moved to a resx file. This applies to all the changes that now throw exceptions.

Shall we localize the strings? In the case we should review all code base.

@iSazonov I don't believe we localize assert strings because they are for debug only usage. Exception strings are handled like any other display string.

@dantraMSFT In this case, I think there is no point in transferring these throw debug strings to the resource files.

@iSazonov: I believe there is. We are effectively creating new strings that are displayed to the user. The fact that they were previously assert strings doesn't change that, IMHO.

What about resx?
Should I move strings to CsvCommandStrings.resx?

We just discuss this becouse of never do this previously.

Moved.

@iSazonov: There already is a guideline in docs\dev-process\coding-guidelines.

Resource strings used for errors or UI should be put in resource files (.resx) so that they can be localized later.

With few, ahem, exceptions, strings passed as the message to an exception are error strings and should be in the resx file. The fact that hit used to be a dbg.assert doesn't change this (IMHO).

As far as the string used in an Assert, I prefer to avoid them, especially when not backed up by code, They are a useful debugging aid though but I would not expect the strings to be localized.

@dantraMSFT Thanks for clarify!