Make the build step fail when the curl operation fails.#6961
Make the build step fail when the curl operation fails.#6961TravisEz13 merged 1 commit intoPowerShell:masterfrom
Conversation
|
|
|
We could also just redirect to the target file even if I understand the desire to show its content in the build logs with |
Without the pipefail, the step always succeeds and the layer gets cached, resulting in confusion during the next step failing and subsequent rebuild attempt.
|
This did not work on either Ubuntu image. I've reverted the change in the new repo I mentioned on another thread so far only for the Ubuntu images. |
|
Ah, on Ubuntu, |
|
@adelton you could change the shell in the docker file and resubmit the PR for the ubuntu images in the PowerShell-Docker repo. If not, could you at least file an issue? |
|
Do you mean running it all with I wonder if showing the result after the |
|
You wouldn't have to put it in front of every command. You can simply change the shell. See an example of how to change the shell to Windows PowerShell here: |
|
I wouldn't want to mess up with Ubuntu's choice of shell. My attempting to change the Ubuntu Dockerfiles was a mistake which I'm sorry for. |
|
no problem |
PR Summary
Without the
pipefail, the build step always succeeds and the layer gets cached, resulting in confusion during the next step failing and subsequent rebuild attempt.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests