Removed unneeded code that forces ARM platforms to run PowerShell in CL mode#7046
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Jun 13, 2018
PaulHigin:remove-unneeded-armclmode
Merged
Removed unneeded code that forces ARM platforms to run PowerShell in CL mode#7046TravisEz13 merged 1 commit intoPowerShell:masterfrom PaulHigin:remove-unneeded-armclmode
TravisEz13 merged 1 commit intoPowerShell:masterfrom
PaulHigin:remove-unneeded-armclmode
Conversation
TravisEz13
approved these changes
Jun 11, 2018
Member
|
This was for a new platform I don't think docs updates are needed. I don't think to go from a restricted to an unrestricted language mode is a breaking change |
anmenaga
approved these changes
Jun 12, 2018
anmenaga
left a comment
There was a problem hiding this comment.
@PaulHigin Any ideas why Constrained Language mode was forced on ARM in the first place?
Member
|
@anmenaga Because of WindowsRT which PowerShell Core doesn't support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This addresses issue #7045. ARM on Windows platform should run in FullLanguage mode by default.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests