Fix trimming of whitespace when table is wrapped#7184
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Jun 27, 2018
Merged
Fix trimming of whitespace when table is wrapped#7184iSazonov merged 1 commit intoPowerShell:masterfrom
iSazonov merged 1 commit intoPowerShell:masterfrom
Conversation
anmenaga
reviewed
Jun 26, 2018
| 1 2 This | ||
| Is some random | ||
| multiline content | ||
|
|
There was a problem hiding this comment.
3 empty lines (here and in 2 other cases below) - are they necessary ?
Member
Author
There was a problem hiding this comment.
It annoys me, too, but that is currently what PowerShell outputs. We should probably look into that as a separate issue. Created #7186
anmenaga
approved these changes
Jun 26, 2018
iSazonov
approved these changes
Jun 27, 2018
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
Seems we catch all bug and now have full test set. Then we could re-write the formatting code with Span to get more clear, fast and reliable code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The original algorithm used math to determine the last column that had content, however, it didn't work correctly when
-Wrapis used withFormat-Table. Fix is to use a simpler brute force approach by checking it cell in the table to determine if it's the last column in that row with content so that we trim trailing whitespace correctly.Fix #7179
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests