Skip to content

Fix sdk package#7431

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:FixSDKPackage
Aug 3, 2018
Merged

Fix sdk package#7431
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:FixSDKPackage

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Aug 1, 2018

Fix #7339

PR Summary

SDK has some missing dependencies which makes the SDK unusable.

PR Checklist

"Microsoft.WSMan.Management.dll",
"Microsoft.WSMan.Runtime.dll",
"System.Management.Automation.dll")
"System.Management.Automation.dll",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: with this format, the commas aren't needed and if you close it on a new line you won't delete a line each time you add an entry.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Don't what to make this change now if you are ok with it.

@daxian-dbw daxian-dbw merged commit ac8ac4f into PowerShell:master Aug 3, 2018
@adityapatwardhan adityapatwardhan deleted the FixSDKPackage branch August 3, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.PowerShell.SDK version 6.1.0-preview.4 fails at InitialSessionState.CreateDefault()

3 participants