Update the 'HelpUri' for 'Get-ExperimentalFeature'#7466
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Aug 8, 2018
Merged
Update the 'HelpUri' for 'Get-ExperimentalFeature'#7466daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
Member
|
The two changes are not related. I think we should not club them together in a single PR. |
Member
Author
|
@adityapatwardhan OK, I will separate them into two PRs. |
Member
Author
|
@adityapatwardhan This PR has been updated to only contains the help uri change. |
adityapatwardhan
requested changes
Aug 7, 2018
| /// Implements Get-ExperimentalFeature cmdlet. | ||
| /// </summary> | ||
| [Cmdlet(VerbsCommon.Get, "ExperimentalFeature", HelpUri = "")] | ||
| [Cmdlet(VerbsCommon.Get, "ExperimentalFeature", HelpUri = "https://go.microsoft.com/fwlink/?linkid=2007351")] |
Member
There was a problem hiding this comment.
Please add a test for this by adding an entry at: https://github.com/PowerShell/PowerShell/blob/master/test/powershell/engine/Help/assets/HelpURI/V3Cmdlets.csv
Member
Author
There was a problem hiding this comment.
Will that test work when the URI currently points to nowhere?
Member
Author
There was a problem hiding this comment.
Done. csv file updated.
adityapatwardhan
approved these changes
Aug 7, 2018
TravisEz13
approved these changes
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the 'HelpUri' for 'Get-ExperimentalFeature'.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests