Skip to content

WIP: Add VSTS daily and feature tag support#7658

Closed
TravisEz13 wants to merge 27 commits intoPowerShell:masterfrom
TravisEz13:add_daily_builds
Closed

WIP: Add VSTS daily and feature tag support#7658
TravisEz13 wants to merge 27 commits intoPowerShell:masterfrom
TravisEz13:add_daily_builds

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Aug 29, 2018 •
edited
Loading

PR Summary

Add VSTS daily and feature tag support

PR Checklist

@TravisEz13 TravisEz13 force-pushed the add_daily_builds branch 7 times, most recently from 1a7a660 to 744a301 Compare August 31, 2018 20:44
@TravisEz13 TravisEz13 changed the title Add VSTS daily and feature tag support WIP: Add VSTS daily and feature tag support Aug 31, 2018
@TravisEz13 TravisEz13 mentioned this pull request Aug 31, 2018
Merged
11 tasks
@TravisEz13 TravisEz13 force-pushed the add_daily_builds branch 2 times, most recently from d4c77d9 to 1659030 Compare September 14, 2018 23:35
daxian-dbw
daxian-dbw reviewed Sep 17, 2018
View reviewed changes
build.psm1 Outdated
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems not complete.

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Sep 17, 2018

@adityapatwardhan mentioned running all tests for PRs. If we go with that, then we won't be needing the tags.

@TravisEz13 TravisEz13 force-pushed the add_daily_builds branch 6 times, most recently from 2c6cfc3 to 31debca Compare September 18, 2018 23:11
@TravisEz13
[Feature] update windows VSTS to support [feature] tag
1ea009a
@TravisEz13
Add logging about why we are exiting unelevated logging loop
04df8a0 
remove code to wait on process
1. it was causing issues
2. the calling code waits
shorten timeout
Add timeout when running as non-admin
Don't switch to non-admin user on AppVeyor
give everyone full access to the buffer file/folder
use non-admin user to run tests
Create non-admin user
@TravisEz13
complete comment
c62d245
@TravisEz13
fix build issues
eab1c87
@TravisEz13
fix typo in creating releasetag
2745401
@TravisEz13
fix preReleaseVersion
0b5dd72
@TravisEz13
set permission on output file
0fdffd3
@TravisEz13
load environment in new process
0b64667
@TravisEz13
use arguments instead of argument list
1719c45
@TravisEz13
fix duplicate key issue
40c90fc
@TravisEz13
remove TMPDIR
86f0854
@stale
Copy link
Copy Markdown

stale bot commented Oct 19, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Oct 19, 2018
@TravisEz13
Copy link
Copy Markdown
Member Author

TravisEz13 commented Oct 20, 2018

I will come back to this.

@stale stale bot removed the Stale label Oct 20, 2018
@TravisEz13 TravisEz13 closed this Nov 13, 2018
@TravisEz13
Copy link
Copy Markdown
Member Author

TravisEz13 commented Nov 13, 2018

This was merged as #8220 . Thank @PaulHigin

@TravisEz13 TravisEz13 deleted the add_daily_builds branch November 13, 2018 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@dantraMSFT dantraMSFT Awaiting requested review from dantraMSFT

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TravisEz13 @daxian-dbw @adityapatwardhan