Skip to content

OS X build compatibility and readme updates#8

Merged
andyleejordan merged 2 commits intomasterfrom
readme
Jan 15, 2016
Merged

OS X build compatibility and readme updates#8
andyleejordan merged 2 commits intomasterfrom
readme

Conversation

@andyleejordan
Copy link
Copy Markdown
Member

No description provided.

Shared libraries are .dylib (not .so) so use a wildcard. Recent
dotnet-cli builds will guess the correct runtime when not supplied.
@andyleejordan andyleejordan added the Issue-Enhancement the issue is more of a feature request than a bug label Jan 15, 2016
@daviwil
Copy link
Copy Markdown
Contributor

daviwil commented Jan 15, 2016

Nice! Does this mean this works on OS X now, or just that it should work soon?

@andyleejordan
Copy link
Copy Markdown
Member Author

I built and ran it on OS X last night 😄 However, I made some changes in monad that aren't quite tested on OS X yet... let me go do that.

@daviwil
Copy link
Copy Markdown
Contributor

daviwil commented Jan 15, 2016

Either way, that is supremely awesome!

@andyleejordan
Copy link
Copy Markdown
Member Author

Just tested, still working on OS X, and the majority of our Pester tests pass too. The native tests fail, but it's a failure of a test itself, not the library.

It also compiles on Windows, I'm just having to adjust our guards to get it running. I'm hopeful it'll be soon.

@daviwil
Copy link
Copy Markdown
Contributor

daviwil commented Jan 15, 2016

I think you've named this repo incorrectly ;)

@andyleejordan
Copy link
Copy Markdown
Member Author

I made a point about that actually, that the name was going to be a misnomer very soon 😃

@andyleejordan andyleejordan merged commit 056d6ba into master Jan 15, 2016
@andyleejordan andyleejordan deleted the readme branch January 15, 2016 20:48
@paulcallen
Copy link
Copy Markdown
Contributor

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Enhancement the issue is more of a feature request than a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants