Code cleanup: convert usage of String to string#8520
Closed
SteveL-MSFT wants to merge 1 commit intoPowerShell:masterfrom
Closed
Code cleanup: convert usage of String to string#8520SteveL-MSFT wants to merge 1 commit intoPowerShell:masterfrom
SteveL-MSFT wants to merge 1 commit intoPowerShell:masterfrom
Conversation
11 tasks
Member
|
Please ignore my previous comment. I didn't notice this PR is specifically targeting |
daxian-dbw
approved these changes
Dec 22, 2018
iSazonov
approved these changes
Dec 22, 2018
Collaborator
|
GitHub "Load Diff" is very slow 😕 For such large PRs I think it is better to make one commit per module/assembly. |
Collaborator
|
@SteveL-MSFT Please resolve merge conflicts. |
c14ac38 to
a13518e
Compare
Collaborator
|
@SteveL-MSFT Merge conflicts :-( |
This was referenced Dec 28, 2018
Collaborator
|
@SteveL-MSFT Can we close the PR? Seems all fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A scan of the code indicates I can simply search and replace on:
String.<= this one is preceded by a single space!String.(String.and fix the casing. Only two lines I had to manually fix in SecureStringCommands which has a
Stringparameter so put those back.Spent a bit of time reviewing each of the changes in this PR so a quick scan from someone else should be sufficient.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests