help function shouldn't use pager for AliasHelpInfo#8552
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Jan 7, 2019
Merged
help function shouldn't use pager for AliasHelpInfo#8552adityapatwardhan merged 3 commits intoPowerShell:masterfrom
help function shouldn't use pager for AliasHelpInfo#8552adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Dec 28, 2018
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
With one minor comment.
iSazonov
approved these changes
Dec 28, 2018
adityapatwardhan
requested changes
Jan 7, 2019
adityapatwardhan
approved these changes
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
helpfunction passes the returned content to a pager unless it is of typeHelpInfoShort(used when multiple matches found). This includes passingAliasHelpInfowhich is short enough to not require passing to the pager. Fix is to simply pass output to pipeline if the result type isAliasHelpInforather than through the pager.#8541
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests