Skip to content

Build package build using ubuntu 18.04 image#8666

Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom
adityapatwardhan:ChangePackageImageTo16_04
Jan 16, 2019
Merged

Build package build using ubuntu 18.04 image#8666
TravisEz13 merged 5 commits intoPowerShell:masterfrom
adityapatwardhan:ChangePackageImageTo16_04

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Jan 16, 2019 •
edited
Loading

PR Summary

Change the base image for package builds from ubuntu14.04 to ubuntu 18.04 due to failure in installing fpm.

PR Checklist

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Jan 16, 2019

The ubuntu.14.04_amd64.deb was tested from a private build on a ubuntu.14.04 container

daxian-dbw
daxian-dbw approved these changes Jan 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan mentioned this pull request Jan 16, 2019
Closed
11 tasks
@adityapatwardhan adityapatwardhan changed the title Build package build using ubuntu 16.04 image Build package build using ubuntu 18.04 image Jan 16, 2019
@TravisEz13 TravisEz13 merged commit f03cafb into PowerShell:master Jan 16, 2019
@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 17, 2019
@adityapatwardhan adityapatwardhan deleted the ChangePackageImageTo16_04 branch January 25, 2019 23:46
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@adityapatwardhan @TravisEz13
Build package build using ubuntu 18.04 image (PowerShell#8666)
b9d7006 
# Conflicts:
#	tools/releaseBuild/build.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+1 more reviewer

@RDIL RDIL RDIL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adityapatwardhan @daxian-dbw @TravisEz13 @RDIL @iSazonov