Update code to use single method to check if path is UNC#8680
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Jan 23, 2019
Merged
Update code to use single method to check if path is UNC#8680adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
11 tasks
anmenaga
approved these changes
Jan 18, 2019
Collaborator
It seems we have a gap in the tests :-( |
adityapatwardhan
approved these changes
Jan 18, 2019
Collaborator
|
@SteveL-MSFT I still believe that we need tests because we did not catch the problem previously in tests and we can create a regression. |
Member
Author
|
@iSazonov agree we have a test gap, but it's unclear where the simple verification of seeing if the path started with two backslashes would fail which is why I said "potentially". The |
Collaborator
|
@SteveL-MSFT We'll find this when we create FileSystem provider V2. :-) |
iSazonov
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The code had a simple (potentially incorrect) check if path is UNC and other code relied on a pinvoke to a win32 api. There is an existing utility method to check if a path is UNC using the URI class. Update all code to use this single utility method.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests