Skip to content

Update README.md to fix contribute and support sections#8684

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
DanielSSilva:patch-1
Jan 18, 2019
Merged

Update README.md to fix contribute and support sections#8684
daxian-dbw merged 1 commit intoPowerShell:masterfrom
DanielSSilva:patch-1

Conversation

@DanielSSilva
Copy link
Copy Markdown
Contributor

PR Summary

The last two commits to this file "broke" both "Developing and contributing"(link is missing) and "Support" (don't know what it didn't format correctly.
This commit fixes both cases.

PR Context

As stated above, two links were sort of broken.

PR Checklist

The last two commits to this file "broke" both  "Developing and contributing"(link is missing) and "Support" (don't know what it didn't format correctly.
This commit fixes both cases.
Copy link
Copy Markdown
Contributor

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets my approval since I broke it

@RDIL
Copy link
Copy Markdown
Contributor

RDIL commented Jan 18, 2019

But also please update the title to fit our contribution guidelines @DanielSSilva.

@DanielSSilva DanielSSilva changed the title Update README.md Update README.md to fix contribute and support sections Jan 18, 2019
@DanielSSilva
Copy link
Copy Markdown
Contributor Author

I think that now is good to go.
Sorry

@RDIL
Copy link
Copy Markdown
Contributor

RDIL commented Jan 18, 2019

Looks good enough now. If needed maintainers will change it again.

Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @DanielSSilva!

@daxian-dbw daxian-dbw merged commit 7054096 into PowerShell:master Jan 18, 2019
@daxian-dbw
Copy link
Copy Markdown
Member

Sign. squash and merge failed and GitHub asked me to retry. However, clicking the retry make it merged with a merge commit ... 🤕

@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 18, 2019
@RDIL
Copy link
Copy Markdown
Contributor

RDIL commented Jan 18, 2019

OOF! 🤕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants