Skip to content

Update GitHub templates#8792

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
iSazonov:update-templates
Jan 31, 2019
Merged

Update GitHub templates#8792
TravisEz13 merged 2 commits intoPowerShell:masterfrom
iSazonov:update-templates

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Jan 30, 2019 •
edited
Loading

PR Summary

Update GitHub templates.
Feel free add commits if needed.

PR Context

Now we have many issues with bug label what doesn't look right :-( I think the label should be assigned only for confirmed bugs.
Also [DOCS] and others in title look superfluous.

PR Checklist

@iSazonov iSazonov requested a review from joeyaiello as a code owner January 30, 2019 05:23
@iSazonov iSazonov mentioned this pull request Jan 30, 2019
Merged
11 tasks
TravisEz13
TravisEz13 reviewed Jan 30, 2019
View reviewed changes
.github/ISSUE_TEMPLATE/Bug_Report.md Outdated
title: "[BUG] My bug report"
labels: Issue-Bug
title: "My bug report"
labels: Issue-Discussion
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe question would be a better place to start

Copy link
Copy Markdown
Collaborator Author

@iSazonov iSazonov Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand the comment.

Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @TravisEz13 means the label Issue-Question

Copy link
Copy Markdown
Collaborator Author

@iSazonov iSazonov Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jan 30, 2019

@PaulHigin @adityapatwardhan
Linux failure is read but unrelated to this PR

FPM failed to install

2019-01-30T05:25:33.5365431Z ERROR:  Error installing fpm:
2019-01-30T05:25:33.5366069Z 	ERROR: Failed to build gem native extension.
2019-01-30T05:25:33.5366505Z 
2019-01-30T05:25:33.5367277Z     current directory: /var/lib/gems/2.3.0/gems/childprocess-1.0.0/ext
2019-01-30T05:25:33.5367474Z /usr/bin/ruby2.3 mkrf_conf.rb
2019-01-30T05:25:33.5367645Z 
2019-01-30T05:25:33.5368132Z current directory: /var/lib/gems/2.3.0/gems/childprocess-1.0.0/ext
2019-01-30T05:25:33.5368905Z /usr/bin/ruby2.3 -rubygems /usr/share/rubygems-integration/all/gems/rake-10.5.0/bin/rake RUBYARCHDIR=/var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/childprocess-1.0.0 RUBYLIBDIR=/var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/childprocess-1.0.0
2019-01-30T05:25:33.5369492Z /usr/bin/ruby2.3: No such file or directory -- /usr/share/rubygems-integration/all/gems/rake-10.5.0/bin/rake (LoadError)
2019-01-30T05:25:33.5369656Z 
2019-01-30T05:25:33.5369833Z rake failed, exit code 1
2019-01-30T05:25:33.5370252Z 
2019-01-30T05:25:33.5370724Z Gem files will remain installed in /var/lib/gems/2.3.0/gems/childprocess-1.0.0 for inspection.
2019-01-30T05:25:33.5371210Z Results logged to /var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/childprocess-1.0.0/gem_make.out

2019-01-30T05:41:12.6286957Z WARNING: Package dependency 'fpm' not found. Run Start-PSBootstrap -Package
2019-01-30T05:41:12.6746525Z Get-ChildItem : Cannot find path '/usr/lib64/ruby/gems' because it does not exist.
2019-01-30T05:41:12.6746697Z At /home/vsts/work/1/s/tools/packaging/packaging.psm1:1155 char:25
2019-01-30T05:41:12.6746994Z + ...          $gemsPath = Get-ChildItem -Path /usr/lib64/ruby/gems | Sort- ...
2019-01-30T05:41:12.6747073Z +                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-30T05:41:12.6747366Z + CategoryInfo          : ObjectNotFound: (/usr/lib64/ruby/gems:String) [Get-ChildItem], ItemNotFoundException
2019-01-30T05:41:12.6747431Z + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand
2019-01-30T05:41:12.6747528Z  
2019-01-30T05:41:12.6996141Z Dependency precheck failed!
2019-01-30T05:41:12.6997120Z At /home/vsts/work/1/s/tools/packaging/packaging.psm1:1168 char:13
2019-01-30T05:41:12.6997384Z +             throw "Dependency precheck failed!"
2019-01-30T05:41:12.6997624Z +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-30T05:41:12.6997856Z + CategoryInfo          : OperationStopped: (Dependency precheck failed!:String) [], RuntimeException
2019-01-30T05:41:12.6998078Z + FullyQualifiedErrorId : Dependency precheck failed!

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jan 31, 2019

Filed #8801 for windows failure and restarting

@TravisEz13 TravisEz13 merged commit 5c8a5f3 into PowerShell:master Jan 31, 2019
@iSazonov iSazonov deleted the update-templates branch February 1, 2019 03:07
@TravisEz13 TravisEz13 added CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log and removed CL-Untagged labels Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

Assignees

@TravisEz13 TravisEz13

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iSazonov @TravisEz13 @adityapatwardhan