Fix length check in PSSnapinQualifiedName.GetInstance()#8837
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Feb 8, 2019
hvitved:ps-snaping-qualified-name-get-instance
Merged
Fix length check in PSSnapinQualifiedName.GetInstance()#8837iSazonov merged 2 commits intoPowerShell:masterfrom hvitved:ps-snaping-qualified-name-get-instance
PSSnapinQualifiedName.GetInstance()#8837iSazonov merged 2 commits intoPowerShell:masterfrom
hvitved:ps-snaping-qualified-name-get-instance
Conversation
RDIL
approved these changes
Feb 6, 2019
bergmeister
reviewed
Feb 6, 2019
iSazonov
approved these changes
Feb 7, 2019
Collaborator
|
@bergmeister The code is used for modules. If I remember correctly most of SnapIn code already was removed. |
Collaborator
|
@hvitved Please add empty commit with '[Feature]' in the commit header to run all tests. |
Contributor
|
Ok, thanks. Sorry, this was not clear to me given the surrounding variable names. |
Collaborator
|
@hvitved Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I came across this when looking at the alerts for this project on LGTM.com (full disclosure: I work on the C# analysis there). The existing check
splitName.Length < 0is redundant, and I believe it should have beensplitName.Length == 0, since the constructor ofPSSnapinQualifiedNameexpects an array of length 1 or 2.You can see the original alert on LGTM.com here: https://lgtm.com/projects/g/PowerShell/PowerShell/alerts/?mode=tree&ruleFocus=1506101336231
Best regards,
Tom