Skip to content

Fix help paging issues on macOS/Linux and with custom pager that takes arguments#9033

Merged
TravisEz13 merged 6 commits intoPowerShell:masterfrom
rkeithhill:rkeithhill/fix-help-formatting-for-less
Apr 10, 2019
Merged

Fix help paging issues on macOS/Linux and with custom pager that takes arguments#9033
TravisEz13 merged 6 commits intoPowerShell:masterfrom
rkeithhill:rkeithhill/fix-help-formatting-for-less

Conversation

@rkeithhill
Copy link
Copy Markdown
Collaborator

PR Summary

Fix #7175 by using Out-String -Stream -Width before piping to an application. This improves the help experience on macOS and Linux by ensuring lines of help text wrap properly for the given console width.

Fix #8912 by using the PS tokenizer to separate the pager command from arguments if both are specified in $env:PAGER. Also ensures that there is no PowerShell interpretation of arguments to an application by using the stop parsing operator.

PR Context

The current reading experience of all help topics on macOS and Linux is sub-par giving PowerShell Core a bit of a black eye on those platforms. See #7175 for images of what this looks like.

Specify a custom pager with arguments works in v6.1 but is broken in v6.2. This PR fixes this issue - #8912.

PR Checklist

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing parameters to $env:PAGER is broken in 6.2.0-preview.4 Line wrapping in PS Core in-the-box help does not indent appropriately

7 participants