Skip to content

Align name schemes for test files#9034

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
ThreeFive-O:FixTestFileNameScheme
Mar 5, 2019
Merged

Align name schemes for test files#9034
daxian-dbw merged 2 commits intoPowerShell:masterfrom
ThreeFive-O:FixTestFileNameScheme

Conversation

@ThreeFive-O
Copy link
Copy Markdown
Contributor

@ThreeFive-O ThreeFive-O commented Mar 3, 2019

PR Summary

Renames three test files to be in line with the rest of naming scheme of the other test files and the respective cmdlet name.

  • FormatHex.Tests.ps1 -> Format-Hex.Tests.ps1
  • NewTemporaryFile.Tests.ps1 -> New-TemporaryFile.Tests.ps1
  • NewGuid.Tests.ps1 -> New-Guid.Tests.ps1

PR Context

Test files mostly follow the name scheme of the respective cmdlet name in PowerShell.
No code changes are made. It's more of a cosmetic change.

PR Checklist

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Mar 3, 2019

There is still NewGuid.

@ThreeFive-O
Copy link
Copy Markdown
Contributor Author

Thank you very much @iSazonov. I've renamed it and modified the PR description accordingly.

@RDIL
Copy link
Copy Markdown
Contributor

RDIL commented Mar 4, 2019

I feel like this should have the Changelog Automation tag CL-Test since this modifies test files.

@iSazonov iSazonov added CL-Test Indicates that a PR should be marked as a test change in the Change Log and removed CL-Untagged labels Mar 4, 2019
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 017e472 into PowerShell:master Mar 5, 2019
@ThreeFive-O ThreeFive-O deleted the FixTestFileNameScheme branch March 5, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants