Skip to content

Update markdown test dependencies#9075

Merged
iSazonov merged 4 commits intoPowerShell:masterfrom
RDIL:patch-4
Mar 9, 2019
Merged

Update markdown test dependencies#9075
iSazonov merged 4 commits intoPowerShell:masterfrom
RDIL:patch-4

Conversation

@RDIL
Copy link
Copy Markdown
Contributor

@RDIL RDIL commented Mar 6, 2019

PR Summary

Bumps some packages used by the static analysis to the latest version

Bumps the following:

"markdownlint": "^0.11.0" -> "markdownlint": "^0.12.0",
"through2": "^2.0.1" -> "through2": "^3.0.1"

devDependencies:
"gulp-debug": "^3.0.0" -> "gulp-debug": "^4.0.0"

PR Context

Dependencies out of date

PR Checklist

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 7, 2019

cc @TravisEz13

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravisEz13 Can DependaBot monitor this and update?

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 7, 2019

@TravisEz13 please review

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 8, 2019

@iSazonov I've done some research and I know how to set up greenkeeper to bump these dependencies automatically if you want me to set it up.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Mar 8, 2019

@RDIL Thanks! We use depedabot and I don't know does it make sense to add one more.

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 8, 2019

@iSazonov sadly dependabot can only do one language

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Mar 8, 2019

We could consider to switch to greenkeeper.
Update: Dependabot supports package-lock.json

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 8, 2019

@iSazonov the problem with that is greenkeeper is JavaScript ONLY and dependabot can only do ONE language. We will need to use both for it to work.

@TravisEz13
Copy link
Copy Markdown
Member

dependabot definitely supports multiple languages.

@TravisEz13
Copy link
Copy Markdown
Member

Adding a new extension is expensive process for us. Let us see if we can get dependabot to work first.

@TravisEz13
Copy link
Copy Markdown
Member

dependabot has opened #9092, #9093 and #9094

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 8, 2019

Dependabot is stealing my commits 😡

@TravisEz13
Copy link
Copy Markdown
Member

lol

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 8, 2019

this tyranny must be stopped

Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing blocking

@TravisEz13
Copy link
Copy Markdown
Member

@iSazonov if you are okay with this PR, Can you merge it and close the equivalent PRs dependabot opened?

@iSazonov iSazonov merged commit 43487b4 into PowerShell:master Mar 9, 2019
@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 9, 2019
@RDIL RDIL deleted the patch-4 branch March 9, 2019 03:32
@daxian-dbw daxian-dbw added this to the 6.2.0 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants