Fix several problems in WritingPesterTests guideline#9078
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Mar 29, 2019
ThreeFive-O:FixPesterGuideline
Merged
Fix several problems in WritingPesterTests guideline#9078adityapatwardhan merged 2 commits intoPowerShell:masterfrom ThreeFive-O:FixPesterGuideline
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
ThreeFive-O:FixPesterGuideline
Conversation
Contributor
Author
|
@RDIL Maybe you would be kind enough to have a second look on this PR, since you have done a lot of those documentation updates recently. Any suggestions or improvements are welcome. |
Contributor
|
Sure, I can in a few minutes. |
RDIL
reviewed
Mar 6, 2019
RDIL
suggested changes
Mar 8, 2019
Collaborator
JamesWTruher
left a comment
There was a problem hiding this comment.
just a couple things
11 tasks
RDIL
approved these changes
Mar 22, 2019
SteveL-MSFT
approved these changes
Mar 23, 2019
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Great set of edits! Thanks!
adityapatwardhan
approved these changes
Mar 29, 2019
Member
|
@ThreeFive-O Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix several style issues in WritingPesterTests guideline and update best-practice recommendations for writing Pester tests.
PR Context
In PR #9037 it was found that the guideline still has some old recommendations for writing Pester tests.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests