Skip to content

Remove code from CI.psm1 to optionally run Feature tests#9212

Merged
TravisEz13 merged 14 commits intoPowerShell:masterfrom
RDIL:patch-6
Mar 27, 2019
Merged

Remove code from CI.psm1 to optionally run Feature tests#9212
TravisEz13 merged 14 commits intoPowerShell:masterfrom
RDIL:patch-6

Conversation

@RDIL
Copy link
Copy Markdown
Contributor

@RDIL RDIL commented Mar 23, 2019 •
edited
Loading

PR Summary

Makes feature tests run without the tag (which now causes issues)

PR Context

@TravisEz13 said this needed to be done

PR Checklist

@RDIL RDIL changed the title (WIP) remove feature tests Remove feature tests Mar 23, 2019
TravisEz13
TravisEz13 reviewed Mar 23, 2019
View reviewed changes
@RDIL RDIL marked this pull request as ready for review March 24, 2019 01:34
iSazonov
iSazonov reviewed Mar 24, 2019
View reviewed changes
@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2019
@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 26, 2019

@TravisEz13 anything specific you need me to do right now?

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Mar 26, 2019

@RDIL ... I reviewed the usage of test-dailybuild and corrected the logic.

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 26, 2019

Thanks

@TravisEz13 TravisEz13 mentioned this pull request Mar 26, 2019
Closed
@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 26, 2019
TravisEz13
TravisEz13 requested changes Mar 26, 2019
View reviewed changes
docs/testing-guidelines/testing-guidelines.md
One of the following tags must be used:

* `CI` - this tag indicates that the tests in the `Describe` block will be executed as part of the CI/PR process
* `Feature` - tests with this tag will not be executed as part of the CI/PR process, but they will be executed on a daily basis as part of a `cron` driven build.
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this should not be deleteed

TravisEz13
TravisEz13 reviewed Mar 26, 2019
View reviewed changes
docs/testing-guidelines/testing-guidelines.md

* `CI` - this tag indicates that the tests in the `Describe` block will be executed as part of the CI/PR process
* `Feature` - tests with this tag will not be executed as part of the CI/PR process, but they will be executed on a daily basis as part of a `cron` driven build.
They indicate that the test will be validating more behavior, or will be using remote network resources (ex: package management tests)
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be a sub-bullet under feature

@ThreeFive-O
Copy link
Copy Markdown
Contributor

ThreeFive-O commented Mar 27, 2019

@RDIL: Could you please update the PR title and give more details in the summary and context. Right now it could be interpreted that all Pester tests tagged with Feature will be removed, which is certainly not the case.
This PR rather only targets the [feature] tag in commit messages, which were necessary to include Pester tests marked with Feature.

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 27, 2019

Sure

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Mar 27, 2019

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Mar 27, 2019

@TravisEz13, all requests start with the magic word Please.

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 27, 2019

@PoshChan please remind me in 1 hour

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Mar 27, 2019

@RDIL, I do not understand: please remind me in an hour

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Mar 27, 2019

@RDIL, will remind you in 1 hour

@TravisEz13 TravisEz13 changed the title Remove feature tests Remove Code from CI.ps1 to optionally run Feature tests Mar 27, 2019
@TravisEz13 TravisEz13 changed the title Remove Code from CI.ps1 to optionally run Feature tests Remove code from CI.psm1 to optionally run Feature tests Mar 27, 2019
@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Mar 27, 2019

@RDIL, this is the reminder you requested 1 hour ago

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Mar 27, 2019

@TravisEz13 this is the reminder you requested an hour ago

@TravisEz13 TravisEz13 merged commit 1227614 into PowerShell:master Mar 27, 2019
@RDIL RDIL deleted the patch-6 branch March 27, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+1 more reviewer

@vexx32 vexx32 vexx32 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

6 participants

@RDIL @TravisEz13 @ThreeFive-O @PoshChan @iSazonov @vexx32