Check to be sure that the test result file has actual results before uploading#9253
Merged
TravisEz13 merged 3 commits intoPowerShell:masterfrom Apr 1, 2019
Merged
Conversation
…uploading VSTS produces a warning if the result set is 0, we will skip uploading this to avoid the warning and better support automation scenarios.
TravisEz13
reviewed
Mar 30, 2019
TravisEz13
requested changes
Mar 30, 2019
Member
TravisEz13
left a comment
There was a problem hiding this comment.
Make sure XUnit results are published.
Co-Authored-By: JamesWTruher <[email protected]>
TravisEz13
approved these changes
Apr 1, 2019
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@TravisEz13, all requests start with the magic word: Please |
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@TravisEz13, will remind you in 1 hour |
Collaborator
|
@TravisEz13, this is the reminder you requested 1 hour ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
VSTS produces a warning if the result set is 0, we will skip uploading this to avoid the warning and better support automation scenarios.
PR Context
We have automation which checks our test results and if the result set is 0 for that file, a warning is produced. This PR will avoid uploading that file into the test results (which is valid, as there are no run tests). We will still add the file to our artifact list for completeness.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.