Add CI for install-powershell.sh and amazon linux#9314
Merged
TravisEz13 merged 8 commits intoPowerShell:masterfrom Apr 8, 2019
Merged
Add CI for install-powershell.sh and amazon linux#9314TravisEz13 merged 8 commits intoPowerShell:masterfrom
install-powershell.sh and amazon linux#9314TravisEz13 merged 8 commits intoPowerShell:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
c2c30c8 to
fcee2df
Compare
fcee2df to
42325ba
Compare
install-powershell.sh and amazon linux
PaulHigin
suggested changes
Apr 8, 2019
| - /tools/installpsh-redhat.sh | ||
| - /tools/installpsh-suse.sh | ||
| - /tools/install-powershell.ps1 | ||
| - /.vsts-ci/install-ps.yml |
Contributor
There was a problem hiding this comment.
This looks like a circular reference. Why should this file include itself?
Member
Author
There was a problem hiding this comment.
not really, it's just saying run this if this file changes.
adityapatwardhan
approved these changes
Apr 8, 2019
.vsts-ci/install-ps.yml
Outdated
| jobName: InstallPowerShellUbuntu | ||
| pool: Hosted Ubuntu 1604 | ||
| verification: | | ||
| $PSVersionTable |
Member
There was a problem hiding this comment.
Convert to version and throw if not less than 6.2.0
PaulHigin
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add CI for
install-powershell.shand amazon linuxPR Context
see #9285
Also, just making sure we can run CI jobs using our containers.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.